Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gateway secret name unique #589

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Make gateway secret name unique #589

merged 2 commits into from
Jan 13, 2025

Conversation

azgabur
Copy link
Contributor

@azgabur azgabur commented Nov 13, 2024

Having the same secret for multiple listeners is now disallowed.
Kuadrant/kuadrant-operator#983
Kuadrant/kuadrant-operator#990 (comment)

Maybe this deserves to become a testcase?

Fixes gateway listeners test.

@azgabur
Copy link
Contributor Author

azgabur commented Nov 14, 2024

Not finished, the cert_secret_name property of Gateway needs to be edited as well. WIP

@jsmolar jsmolar marked this pull request as draft November 18, 2024 09:07
@azgabur
Copy link
Contributor Author

azgabur commented Dec 6, 2024

Pinning httpx version because of deprication of MutableMaping in "extensions" and changes to ssl verify option. We can discuss what to do with it.
https://github.com/encode/httpx/releases/tag/0.28.0

How to refactor in future: https://github.com/encode/httpx/blob/0.28.0/docs/advanced/ssl.md

@azgabur azgabur marked this pull request as ready for review December 6, 2024 20:47
Copy link
Contributor

@trepel trepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I ran test_scale_listeners.py, test_cert_parameters.py, and test_external_ca.py. They passed.

@trepel trepel merged commit 3e1c42e into Kuadrant:main Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants